Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): fix failing arm builds #14022

Merged
merged 1 commit into from
Sep 2, 2024
Merged

chore(ci): fix failing arm builds #14022

merged 1 commit into from
Sep 2, 2024

Conversation

ashwanthgoli
Copy link
Contributor

What this PR does / why we need it:
GOOS=linux GOARCH=arm make loki fails on main
https://github.com/grafana/loki/actions/runs/10658934585/job/29540918814

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@ashwanthgoli ashwanthgoli requested a review from a team as a code owner September 2, 2024 05:11
shantanualsi
shantanualsi approved these changes Sep 2, 2024
View reviewed changes
Copy link
Contributor

@shantanualsi shantanualsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@grafanabot
Copy link
Collaborator

Hello @ashwanthgoli!
Backport pull requests need to be either:

  • Pull requests which address bugs,
  • Urgent fixes which need product approval, in order to get merged,
  • Docs changes.

Please, if the current pull request addresses a bug fix, label it with the type/bug label.
If it already has the product approval, please add the product-approved label. For docs changes, please add the type/docs label.
If the pull request modifies CI behaviour, please add the type/ci label.
If none of the above applies, please consider removing the backport label and target the next major/minor release.
Thanks!

@grafanabot
Copy link
Collaborator

This PR must be merged before a backport PR will be created.

@ashwanthgoli ashwanthgoli added type/bug Somehing is not working as expected and removed missing-labels labels Sep 2, 2024
@ashwanthgoli ashwanthgoli merged commit 281407f into main Sep 2, 2024
64 of 65 checks passed
@ashwanthgoli ashwanthgoli deleted the fix-arm-build branch September 2, 2024 05:36
grafanabot pushed a commit that referenced this pull request Sep 2, 2024
@ashwanthgoli @grafana-delivery-bot
chore(ci): fix failing arm builds (#14022)
4a63a08 
(cherry picked from commit 281407f)
@grafanabot grafanabot mentioned this pull request Sep 2, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shantanualsi shantanualsi shantanualsi approved these changes

Assignees
No one assigned
Labels
backport k218 size/XS type/bug Somehing is not working as expected
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ashwanthgoli @grafanabot @shantanualsi